Mon, 24 Jan 2005

Quote Manager Project -- Day 7

Must...write...test...for anonymous ActionListener...

Let's look at our ActionListener:

        addButton.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                Source source = new Source(QuoteManagerPanel.this.source.getText(), page.getText(), isbn.getText());
                Collection<Person> authors = new ArrayList<Person>();

                for (int i = 0; i < NUMBER_OF_AUTHORS; i++)
                    if (authorPanels[i].hasText())
                        authors.add(new Person(authorPanels[i].getFirstName(), authorPanels[i].getLastName(), authorPanels[i].getUrl()));

                Person quoter = new Person(quoterFirstName.getText(), quoterLastName.getText(), quoterUrl.getText());
                new Quote(quoteText.getText(), source, authors, quoter);
            }
        });

    private void layoutForm() {
        GridBagConstraints constraints = new GridBagConstraints();
        constraints.anchor = GridBagConstraints.WEST;

        int y = 0;
        addLabel("Quote", constraints, y++);
        addField(quoteText, constraints);
        addLabel("Source", constraints, y++);
        addField(source, constraints);
        addLabel("ISBN", constraints, y++);
        addField(isbn, constraints);
        addLabel("Page", constraints, y++);
        addField(page, constraints);

        constraints.gridwidth = GridBagConstraints.REMAINDER;
        constraints.gridx = 0;

        for (int i = 0; i < NUMBER_OF_AUTHORS; i++) {
            constraints.gridy = y++;
            add(authorPanels[i], constraints);
        }

        layoutQuoter(constraints, y);
       y += 2;

        constraints.anchor = GridBagConstraints.EAST;
        constraints.gridx = 0;
        constraints.gridwidth = GridBagConstraints.REMAINDER;
        constraints.gridy = y++;
        add(addButton, constraints);
    }

    private void layoutQuoter(GridBagConstraints constraints, int y) {
        addLabel("Quoter", constraints, y);
        addFullName(quoterFirstName, quoterLastName, constraints);
        addLabel("URL", constraints, y+1);
        addField(quoterUrl, constraints);
    }

    private void layoutForm() {
        GridBagConstraints constraints = new GridBagConstraints();
        constraints.anchor = GridBagConstraints.WEST;

        int y = 0;
        addLabel("Quote", constraints, y++);
        addField(quoteText, constraints);
        addLabel("Source", constraints, y++);
        addField(source, constraints);
        addLabel("ISBN", constraints, y++);
        addField(isbn, constraints);
        addLabel("Page", constraints, y++);
        addField(page, constraints);

        constraints.gridwidth = GridBagConstraints.REMAINDER;
        constraints.gridx = 0;

        for (int i = 0; i < NUMBER_OF_AUTHORS; i++) {
            constraints.gridy = y++;
            add(authorPanels[i], constraints);
        }

        constraints.gridy = y++;
       add(layoutQuoter(), constraints);

        constraints.anchor = GridBagConstraints.EAST;
        constraints.gridx = 0;
        constraints.gridwidth = GridBagConstraints.REMAINDER;
        constraints.gridy = y++;
        add(addButton, constraints);
    }

    private JPanel layoutQuoter() {
        JPanel quoterPanel = new JPanel(new GridBagLayout());

        GridBagConstraints constraints = new GridBagConstraints();

        constraints.gridx = 0;
        constraints.gridwidth = 1;
        constraints.gridy = 0;
        quoterPanel.add(new JLabel("Quoter"), constraints);

        constraints.gridwidth = GridBagConstraints.RELATIVE;
        constraints.gridx = 1;
        quoterPanel.add(quoterFirstName, constraints);

        constraints.gridwidth = GridBagConstraints.REMAINDER;
        constraints.gridx = 2;
        quoterPanel.add(quoterLastName, constraints);

        constraints.gridx = 0;
        constraints.gridwidth = 1;
        constraints.gridy = 1;
        quoterPanel.add(new JLabel("URL"), constraints);

        constraints.gridwidth = GridBagConstraints.REMAINDER;
        constraints.gridx = 1;
        quoterPanel.add(quoterUrl, constraints);

        return quoterPanel;
    }

QuoterPanel is almost an exact replica of the AuthorPanel. Let's see if I can extract the duplication... Yep, no problem. I created a concrete PersonPanel which was an exact copy of AuthorPanel except that the constructor takes the entire String for the label, rather than the authorNumber. That way when I need a PersonPanel to represent a quoter, I just pass in "Quoter". Pretty simple.

Now my anonymous ActionListener depends on six objects. I can get that down to four if I group the source fields into their own panel. I think I can do this quickly...I've gone through the steps twice already. I'll take some bigger steps and not bore you with the details...

I have a SourcePanel. There is a lot of GridBagLayout duplication between the three different JPanel derivatives, but I'm not going to worry about that right now. It's time to test...

package com.redsquirrel.com.quotes.gui;

import org.jmock.MockObjectTestCase;
import org.jmock.Mock;

public class AddButtonActionListenerTest extends MockObjectTestCase {
    public void testShouldProvideNewQuoteToManager() {
        Mock manager = mock(Manager.class);
        AddButtonActionListener actionListener = new AddButtonActionListener((Manager) manager.proxy());
        actionListener.actionPerformed(null);
    }
}

It passes. Doh! I didn't add any expectations! Here's a simple one...

    public void testShouldProvideNewQuoteToManager() {
        Mock manager = mock(Manager.class);
        manager.expects(once()).method("newQuote").with(isA(Quote.class));

        AddButtonActionListener actionListener = new AddButtonActionListener((Manager) manager.proxy());
        actionListener.actionPerformed(null);
    }

public class AddButtonActionListener implements ActionListener {
    private final Manager manager;

    public AddButtonActionListener(Manager manager) {
        this.manager = manager;
    }

    public void actionPerformed(ActionEvent e) {
        manager.newQuote(new Quote("foo", new Source("foo", "foo", "foo"), new HashSet(), new Person("foo", "foo", "foo")));
    }
}

    public void testShouldProvideNewQuoteToManager() {
        Collection<Person> authors = new HashSet<Person>();
       authors.add(new Person("Dee", "Hock", "http://chaordic.org/"));

       String text = "Community is not about profit, it is about benefit.  We confuse them at our peril.";
       Source source = new Source("Birth of the Chaordic Age", "43", "1576750744");
       Quote expected = new Quote(text, source, authors, null);

        Mock manager = mock(Manager.class);
        manager.expects(once()).method("newQuote").with(eq(expected));

        AddButtonActionListener actionListener = new AddButtonActionListener((Manager) manager.proxy());
        actionListener.actionPerformed(null);
    }

[/projects/quotes] permanent link