Wed, 26 Jan 2005

Quote Manager Project -- Day 8

I could pass the test by changing the hard-coded values of the Quote I'm passing into the Manager (and provide an equals method), but I'd rather get to the point and inject the dependencies that AddButtonActionListener needs to do its work.

My first instinct is to extract interfaces from PersonPanel and SourcePanel in order to mock them more easily, but they would just be a bunch of getters. Bletch. But since I can't think of anything better right now, that's just what I'll do.

Ahh, back to green. That was painful, and I'm doubting if all of the extra steps I just took were worth it. I had IDEA generate equals (and hashCode) for all of my model classes so that I could verify that the expected Quote matched the Quote created by AddButtonActionListener. I also had to create two interfaces: PersonComponent and SourceComponent.

Here's the test:

    public void testShouldProvideNewQuoteToManager() {
        Collection<Person> authors = new HashSet<Person>();
        String firstName = "Dee";
        String lastName = "Hock";
        String url = "http://chaordic.org/";
        authors.add(new Person(firstName, lastName, url));

        String text = "Community is not about profit, it is about benefit.  We confuse them at our peril.";
        String title = "Birth of the Chaordic Age";
        String page = "43";
        String isbn = "1576750744";
        Source source = new Source(title, page, isbn);
        Quote expected = new Quote(text, source, authors, null);

        Mock manager = mock(Manager.class);
        manager.expects(once()).method("newQuote").with(eq(expected));

        Mock mockSource = mock(SourceComponent.class);
        mockSource.expects(once()).method("getTitle").will(returnValue(title));
        mockSource.expects(once()).method("getPage").will(returnValue(page));
        mockSource.expects(once()).method("getIsbn").will(returnValue(isbn));

        Mock mockAuthor = mock(PersonComponent.class);
        mockAuthor.expects(once()).method("hasText").will(returnValue(true));
        mockAuthor.expects(once()).method("getFirstName").will(returnValue(firstName));
        mockAuthor.expects(once()).method("getLastName").will(returnValue(lastName));
        mockAuthor.expects(once()).method("getUrl").will(returnValue(url));

        Collection<PersonComponent> mockAuthors = new HashSet<PersonComponent>();
        mockAuthors.add((PersonComponent) mockAuthor.proxy());

        AddButtonActionListener actionListener = new AddButtonActionListener((Manager) manager.proxy(),
                                                                             text,
                                                                             (SourceComponent) mockSource.proxy(),
                                                                             mockAuthors);
        actionListener.actionPerformed(null);
    }

package com.redsquirrel.com.quotes.gui;

import com.redsquirrel.quotes.model.Person;
import com.redsquirrel.quotes.model.Quote;
import com.redsquirrel.quotes.model.Source;

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.util.Collection;
import java.util.HashSet;

public class AddButtonActionListener implements ActionListener {
    private final Manager manager;
    private final String text;
    private final SourceComponent source;
    private final Collection<PersonComponent> authors;

    public AddButtonActionListener(Manager manager, String text, SourceComponent source, Collection<PersonComponent> authors) {
        this.manager = manager;
        this.text = text;
        this.source = source;
        this.authors = authors;
    }

    public void actionPerformed(ActionEvent e) {
        Source source = new Source(this.source.getTitle(), this.source.getPage(), this.source.getIsbn());

        Collection<Person> authors = new HashSet<Person>();
        for (PersonComponent author : this.authors)
            if (author.hasText())
                authors.add(new Person(author.getFirstName(), author.getLastName(), author.getUrl()));

        //Person quoter = new Person(quoterPanel.getFirstName(), quoterPanel.getLastName(), quoterPanel.getUrl());
        Quote quote = new Quote(text, source, authors, null);

        manager.newQuote(quote);
    }
}

Here's a new test that includes a quoter...

    public void testShouldProvideNewQuoteWithOptionalQuoterToManager() {
        Collection<Person> authors = new HashSet<Person>();
        String firstName = "Frederick";
        String lastName = "Brooks";
        String url = "http://www.cs.unc.edu/~brooks/";
        authors.add(new Person(firstName, lastName, url));

        String quoterFirst = "Jim";
        String quoterLast = "McCarthy";
        String quoterUrl = "http://www.mccarthy-tech.com/";
        Person quoter = new Person(quoterFirst, quoterLast, quoterUrl);

        String text = "I can't emphasize enough the importance of empowerment, of the team being accountable to itself for its success.";
        String title = "The Mythical Man Month";
        String page = "279";
        String isbn = "0201835959";
        Source source = new Source(title, page, isbn);
        Quote expected = new Quote(text, source, authors, quoter);

        Mock manager = mock(Manager.class);
        manager.expects(once()).method("newQuote").with(eq(expected));

        Mock mockSource = mock(SourceComponent.class);
        mockSource.expects(once()).method("getTitle").will(returnValue(title));
        mockSource.expects(once()).method("getPage").will(returnValue(page));
        mockSource.expects(once()).method("getIsbn").will(returnValue(isbn));

        Mock mockAuthor = mock(PersonComponent.class);
        mockAuthor.expects(once()).method("hasText").will(returnValue(true));
        mockAuthor.expects(once()).method("getFirstName").will(returnValue(firstName));
        mockAuthor.expects(once()).method("getLastName").will(returnValue(lastName));
        mockAuthor.expects(once()).method("getUrl").will(returnValue(url));

        Collection<PersonComponent> mockAuthors = new HashSet<PersonComponent>();
        mockAuthors.add((PersonComponent) mockAuthor.proxy());

        Mock mockQuoter = mock(PersonComponent.class);
        mockQuoter.expects(once()).method("getFirstName").will(returnValue(quoterFirst));
        mockQuoter.expects(once()).method("getLastName").will(returnValue(quoterLast));
        mockQuoter.expects(once()).method("getUrl").will(returnValue(quoterUrl));

        AddButtonActionListener actionListener = new AddButtonActionListener((Manager) manager.proxy(),
                                                                             text,
                                                                             (SourceComponent) mockSource.proxy(),
                                                                             mockAuthors,
                                                                             (PersonComponent) mockQuoter.proxy());
        actionListener.actionPerformed(null);
    }

    public void actionPerformed(ActionEvent e) {
        Source source = new Source(this.source.getTitle(), this.source.getPage(), this.source.getIsbn());

        Collection<Person> authors = new HashSet<Person>();
        for (PersonComponent author : this.authors)
            if (author.hasText())
                authors.add(new Person(author.getFirstName(), author.getLastName(), author.getUrl()));

        Person quoter = null;
        if (this.quoter != null)
            quoter = new Person(this.quoter.getFirstName(), this.quoter.getLastName(), this.quoter.getUrl());

        Quote quote = new Quote(text, source, authors, quoter);

        manager.newQuote(quote);
    }

    public void actionPerformed(ActionEvent e) {
        Source source = new Source(this.source);

        Collection<Person> authors = new HashSet<Person>();
        for (PersonComponent author : this.authors)
            if (author.hasText())
                authors.add(new Person(author));

        Person quoter = null;
        if (this.quoter != null)
            quoter = new Person(this.quoter);

        Quote quote = new Quote(text, source, authors, quoter);

        manager.newQuote(quote);
    }

    public void testShouldProvideNewQuoteWithTwoAuthorsToManager() {
        Collection<Person> authors = new HashSet<Person>();
        String firstName = "Mary";
        String lastName = "Poppendieck";
        String url = "http://poppendieck.com/";
        authors.add(new Person(firstName, lastName, url));

        String firstName2 = "Tom";
        String lastName2 = "Poppendieck";
        String url2 = "http://poppendieck.com/";
        authors.add(new Person(firstName2, lastName2, url2));

        String text = "It is necessary to have a reasonable failure rate in order to generate a reasonable amount of information.";
        String title = "Lean Software Development: An Agile Toolkit";
        String page = "19";
        String isbn = "0321150783";
        Source source = new Source(title, page, isbn);
        Quote expected = new Quote(text, source, authors, null);

        Mock manager = mock(Manager.class);
        manager.expects(once()).method("newQuote").with(eq(expected));

        Mock mockSource = mock(SourceComponent.class);
        mockSource.expects(once()).method("getTitle").will(returnValue(title));
        mockSource.expects(once()).method("getPage").will(returnValue(page));
        mockSource.expects(once()).method("getIsbn").will(returnValue(isbn));

        Mock blankAuthor = mock(PersonComponent.class);
        blankAuthor.expects(once()).method("hasText").will(returnValue(false));

        Mock mary = mock(PersonComponent.class);
        mary.expects(once()).method("hasText").will(returnValue(true));
        mary.expects(once()).method("getFirstName").will(returnValue(firstName));
        mary.expects(once()).method("getLastName").will(returnValue(lastName));
        mary.expects(once()).method("getUrl").will(returnValue(url));
`
        Mock tom = mock(PersonComponent.class);
        tom.expects(once()).method("hasText").will(returnValue(true));
        tom.expects(once()).method("getFirstName").will(returnValue(firstName2));
        tom.expects(once()).method("getLastName").will(returnValue(lastName2));
        tom.expects(once()).method("getUrl").will(returnValue(url2));

        Collection<PersonComponent> mockAuthors = new HashSet<PersonComponent>();
        mockAuthors.add((PersonComponent) blankAuthor.proxy());
        mockAuthors.add((PersonComponent) mary.proxy());
        mockAuthors.add((PersonComponent) tom.proxy());

        AddButtonActionListener actionListener = new AddButtonActionListener((Manager) manager.proxy(),
                                                                             text,
                                                                             (SourceComponent) mockSource.proxy(),
                                                                             mockAuthors);
        actionListener.actionPerformed(null);
    }

[/projects/quotes] permanent link